The Witness: Use entity IDs as location IDs directly #5526
+3,526
−3,536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: webhost
NewSoupVi
force-pushed
the
witness_remove_slot_lookup
branch
from
2a7b324 to
5864abc
Compare
NewSoupVi
added
is: refactor/cleanup
NewSoupVi
added
the
waiting-on: peer-review
There was a problem hiding this comment.
Looked through all of the files except player_logic.py. None of the code stood out as an issue to me. Data files seem to be accurately converted to exclude the old AP numbers.
Did not check other files for potentially missing references nor any now unused values or functions. One small comment on a value within the files, otherwise everything I looked over seems fine.
Did not test generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays that we have per-game IDs, making the distinction between entity IDs and location IDs no longer makes sense.
This greatly reduces the size of a Witness slot's slot_data by removing the conversion dict from one to the other.
Changes:
New client: https://github.com/NewSoupVi/The-Witness-Randomizer-for-Archipelago/releases/tag/9.0.0p1
Probably needs more testing (like seed comparisons and mypy checking)